Add millisecond field for time map initialize. #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some integration tests in TCK |
Done |
CPWstatic
reviewed
Sep 7, 2021
| @@ -55,11 +55,16 @@ constexpr int64_t kMaxTimestamp = std::numeric_limits<int64_t>::max() / 10000000 | |||
| return Status::Error("Invalid second number `%ld'.", kv.second.getInt()); | |||
| } | |||
| dt.sec = kv.second.getInt(); | |||
| } else if (kv.first == "millisecond") { | |||
There was a problem hiding this comment.
switch can't process string type.
| tag_date.f_datetime = DateTime("2018-03-04T22:30:40") | ||
| tag_date.f_date = Date({year: 2018, month: 3, day: 4}), | ||
| tag_date.f_time = Time({hour: 22, minute: 1, second: 0, millisecond: 0, microsecond: 0}), | ||
| tag_date.f_datetime = DateTime({year: 2018, month: 3, day: 4, hour: 22, minute: 30, second: 40, millisecond: 0, microsecond: 0}) |
There was a problem hiding this comment.
Why not add a new test case instead of modifying?
There was a problem hiding this comment.
The origin case is tested in other case too.
yixinglu
previously approved these changes
Sep 10, 2021
Aiee
previously approved these changes
Sep 15, 2021
yixinglu
reviewed
Sep 15, 2021
…ock-Hg/nebula into correct/time-millisecond-initialize
Aiee
approved these changes
Sep 23, 2021
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2612