Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra parentheses in CMakeLists.txt #3195

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

junaire
Copy link
Contributor

@junaire junaire commented Oct 24, 2021

Signed-off-by: Jun jun@junz.org

What type of PR is this?

  • bug

Which issue(s) this PR fixes:

close #3194

Release notes:

Please confirm whether to reflect in release notes and how to describe:

None

Signed-off-by: Jun <jun@junz.org>
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2021

CLA assistant check
All committers have signed the CLA.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Oct 24, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #3195 (b7cd723) into master (cd2ecb9) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
- Coverage   85.33%   85.23%   -0.11%     
==========================================
  Files        1295     1295              
  Lines      118276   118282       +6     
==========================================
- Hits       100930   100815     -115     
- Misses      17346    17467     +121     
Impacted Files Coverage Δ
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/kvstore/raftex/Host.cpp 67.14% <0.00%> (-8.07%) ⬇️
src/meta/processors/job/RebuildJobExecutor.cpp 35.71% <0.00%> (-4.77%) ⬇️
src/kvstore/Part.cpp 54.13% <0.00%> (-3.42%) ⬇️
src/common/datatypes/HostAddrOps-inl.h 75.67% <0.00%> (-2.71%) ⬇️
src/graph/executor/StorageAccessExecutor.h 64.10% <0.00%> (-2.57%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 85.64% <0.00%> (-2.40%) ⬇️
src/meta/processors/job/JobManager.cpp 75.00% <0.00%> (-2.09%) ⬇️
src/meta/processors/job/MetaJobExecutor.cpp 61.90% <0.00%> (-2.05%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2ecb9...b7cd723. Read the comment docs.

@yixinglu yixinglu merged commit 46ed98f into vesoft-inc:master Oct 24, 2021
@junaire junaire deleted the fix-cmake branch October 24, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when building with ninja
5 participants