move balancer to jobManager #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
force-pushed
the
lwh
branch
3 times, most recently
from
f544809
to
7020a45
Compare
liwenhui-soul
added
ready-for-testing
liwenhui-soul
requested review from
critical27,
bright-starry-sky and
liuyu85cn
liwenhui-soul
force-pushed
the
lwh
branch
3 times, most recently
from
27b6e8b
to
b8e3d17
Compare
critical27
reviewed
Nov 11, 2021
liwenhui-soul
force-pushed
the
lwh
branch
4 times, most recently
from
8b9d509
to
0b6fb67
Compare
liuyu85cn
reviewed
Nov 12, 2021
critical27
reviewed
Nov 12, 2021
liwenhui-soul
force-pushed
the
lwh
branch
2 times, most recently
from
c885846
to
3e82ca5
Compare
critical27
added
doc affected
Codecov Report
@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
+ Coverage 85.24% 85.37% +0.12%
==========================================
Files 1305 1287 -18
Lines 120347 119667 -680
==========================================
- Hits 102595 102168 -427
+ Misses 17752 17499 -253
Continue to review full report at Codecov.
|
critical27
reviewed
Nov 15, 2021
critical27
approved these changes
Nov 16, 2021
|
Good job |
critical27
requested review from
panda-sheep,
bright-starry-sky,
cangfengzhs,
darionyaphet,
pengweisong,
SuperYoko and
wenhaocs
wenhaocs
reviewed
Nov 16, 2021
| processors/admin/Balancer.cpp | ||
| processors/admin/BalancePlan.cpp | ||
| processors/admin/BalanceTask.cpp | ||
| processors/job/BalancePlan.cpp |
wenhaocs
approved these changes
Nov 16, 2021
| @@ -9,11 +9,11 @@ set(expression_test_common_libs | |||
| $<TARGET_OBJECTS:network_obj> | |||
| $<TARGET_OBJECTS:fs_obj> | |||
| $<TARGET_OBJECTS:stats_obj> | |||
| $<TARGET_OBJECTS:datatypes_obj> | |||
There was a problem hiding this comment.
Can I ask the purpose of this order change?
|
both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
close #xxx
（If it is requirement, issue(s) number must be listed.）
What this PR does / why we need it?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: