Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some useless code #3341

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

darionyaphet
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Nov 23, 2021
@czpmango
Copy link
Contributor

collectZoneParts exists in this pr #3254.
If you delete it, please give some descriptions to explain why to delete it.
All review intentions should be recorded.

@darionyaphet
Copy link
Contributor Author

collectZoneParts exists in this pr #3254. If you delete it, please give some descriptions to explain why to delete it. All review intentions should be recorded.

collectZoneParts not used and have replaced by assembleZoneParts

@yixinglu yixinglu merged commit bf0c3a1 into vesoft-inc:master Nov 23, 2021
@darionyaphet darionyaphet deleted the clean-balance branch November 23, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants