CI improvements #3298
Merged
CI improvements #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jackwener
added
community
jsoref
force-pushed
the
ci-improvements
branch
from
37aa836
to
e3a2746
Compare
yixinglu
reviewed
Nov 10, 2021
Use GITHUB_BASE_REF because a PR can easily have more than one commit: https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables Switch CLANG_HOME handling to support debian/ubuntu installed clang-format or a user's installation at some other location. Install clang-format-10 if it isn't installed in CI (this is mostly for nektos/act where images might be thinner than the GitHub standard).
In order to see what changes this PR is making, we need to get the base commit.
jsoref
force-pushed
the
ci-improvements
branch
from
d106fa5
to
0ec8a5c
Compare
yixinglu
approved these changes
Nov 19, 2021
HarrisChu
approved these changes
Nov 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #3298 +/- ##
==========================================
- Coverage 85.29% 85.23% -0.07%
==========================================
Files 1289 1289
Lines 119969 119981 +12
==========================================
- Hits 102329 102264 -65
- Misses 17640 17717 +77
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
gherkin-fmtso that it doesn't yield an error during GitHub Workflow lint CI.gherkin-fmtso that they don't have to install it locallyWhich issue(s)/PR(s) this PR relates to?
#3297
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: