Support delete vertex without edge #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why #3123 need this? |
It is part of the |
Codecov Report
@@ Coverage Diff @@
## master #3316 +/- ##
=======================================
Coverage 85.23% 85.24%
=======================================
Files 1289 1288 -1
Lines 119974 119889 -85
=======================================
- Hits 102265 102201 -64
+ Misses 17709 17688 -21
Continue to review full report at Codecov.
|
cangfengzhs
requested review from
a team,
critical27,
CPWstatic and
yixinglu
CPWstatic
approved these changes
Dec 7, 2021
| if (withEdge_) { | ||
| std::vector<storage::cpp2::EdgeProp> edgeProps; | ||
| // make edgeRefs and edgeProp | ||
| auto index = 0u; |
There was a problem hiding this comment.
You could iterates both edgeTypes_ and edgeNames_ instead of using the index.
There was a problem hiding this comment.
I did not modify these codes, and just move them into an if statement.
Shylock-Hg
added
the
incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
support delete vertex without edge
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: