Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/view vertices edges #3320

Merged
merged 44 commits into from
Dec 9, 2021

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Nov 16, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Close #3106

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Nov 16, 2021
@Shylock-Hg Shylock-Hg added this to the v3.0.0 milestone Nov 16, 2021
@Shylock-Hg Shylock-Hg marked this pull request as draft November 16, 2021 08:08
@Shylock-Hg Shylock-Hg mentioned this pull request Nov 18, 2021
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #3320 (eb6307b) into master (6ccf173) will increase coverage by 0.09%.
The diff coverage is 84.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
+ Coverage   85.25%   85.34%   +0.09%     
==========================================
  Files        1278     1289      +11     
  Lines      119277   119811     +534     
==========================================
+ Hits       101688   102257     +569     
+ Misses      17589    17554      -35     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/common/graph/Response.h 45.66% <ø> (ø)
src/common/meta/SchemaManager.h 50.00% <ø> (ø)
src/graph/context/ast/CypherAstContext.h 100.00% <ø> (ø)
src/graph/planner/plan/PlanNode.h 81.25% <ø> (ø)
src/graph/visitor/ExtractFilterExprVisitor.cpp 50.46% <36.36%> (-18.29%) ⬇️
src/clients/storage/StorageClient.cpp 78.43% <50.00%> (+6.45%) ⬆️
src/graph/validator/GoValidator.cpp 96.25% <72.72%> (-0.94%) ⬇️
.../optimizer/rule/PushFilterDownScanVerticesRule.cpp 73.91% <73.91%> (ø)
src/common/graph/ExecutionResponseOps-inl.h 62.85% <85.71%> (+1.71%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ab058...eb6307b. Read the comment docs.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. One thing to note is that the syntax of match may be modified in #3255

@Shylock-Hg Shylock-Hg added the doc affected PR: improvements or additions to documentation label Nov 30, 2021
@Shylock-Hg Shylock-Hg marked this pull request as ready for review November 30, 2021 09:05
CPWstatic
CPWstatic previously approved these changes Dec 8, 2021
@CPWstatic CPWstatic merged commit bc1aac6 into vesoft-inc:master Dec 9, 2021
@foesa-yang foesa-yang added this to Done in Nebula Docs Jan 17, 2022
@Shylock-Hg Shylock-Hg deleted the feature/view-vertices-edges branch February 9, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
Development

Successfully merging this pull request may close these issues.

View sample data for tags & edges
5 participants