Support filter in scan. #3329
Merged
Support filter in scan. #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3329 +/- ##
==========================================
- Coverage 85.31% 85.30% -0.02%
==========================================
Files 1289 1289
Lines 120073 120197 +124
==========================================
+ Hits 102442 102535 +93
- Misses 17631 17662 +31
Continue to review full report at Codecov.
|
critical27
reviewed
Nov 19, 2021
| @@ -64,6 +64,13 @@ nebula::cpp2::ErrorCode ScanEdgeProcessor::checkAndBuildContexts(const cpp2::Sca | |||
| std::vector<cpp2::EdgeProp> returnProps = {*req.return_columns_ref()}; | |||
| ret = handleEdgeProps(returnProps); | |||
| buildEdgeColName(returnProps); | |||
| ret = buildFilter(req, [](const cpp2::ScanEdgeRequest& r) -> const std::string* { | |||
There was a problem hiding this comment.
How about just override the buildFilter? Passing another function here is a little weird.
There was a problem hiding this comment.
The override code is almost same, so I don't do it as this.
There was a problem hiding this comment.
Em... Actually the lambda is almost same as well. Not so important.
critical27
approved these changes
Nov 22, 2021
panda-sheep
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Support push-down filter of scan interface.
Which issue(s)/PR(s) this PR relates to?
Sub job of #3320
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: