Support zone operations #3444
Merged
Support zone operations #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
force-pushed
the
zone
branch
4 times, most recently
from
8e2305d
to
1c087b5
Compare
darionyaphet
added
ready-for-testing
darionyaphet
force-pushed
the
zone
branch
5 times, most recently
from
c040cf8
to
d9e663e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
==========================================
- Coverage 85.19% 79.14% -6.06%
==========================================
Files 1306 1251 -55
Lines 122158 105097 -17061
==========================================
- Hits 104078 83174 -20904
- Misses 18080 21923 +3843
Continue to review full report at Codecov.
|
critical27
reviewed
Dec 20, 2021
| } | ||
| folly::Baton<true, std::atomic> baton; | ||
| auto result = nebula::cpp2::ErrorCode::SUCCEEDED; | ||
| kvstore_->asyncMultiRemove(kDefaultSpaceId, |
There was a problem hiding this comment.
Why don't use LogBatch? You can't promise it is atomic. So as DropHost and other processor, please check it
There was a problem hiding this comment.
Check all processor zone related, e.g. DropHostProcessor in previous PR
darionyaphet
force-pushed
the
zone
branch
6 times, most recently
from
b6b8f8d
to
fb78eb1
Compare
7 tasks
darionyaphet
force-pushed
the
zone
branch
5 times, most recently
from
3267003
to
9880cf3
Compare
panda-sheep
reviewed
Dec 28, 2021
liuyu85cn
previously approved these changes
Dec 28, 2021
|
Don't merge pls |
darionyaphet
dismissed stale reviews from liuyu85cn and panda-sheep
via
bdf2fa7
darionyaphet
force-pushed
the
zone
branch
2 times, most recently
from
bdf2fa7
to
0d5cda7
Compare
critical27
approved these changes
Dec 28, 2021
panda-sheep
approved these changes
Dec 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: