Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support auto registe when storage start up #3548

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Support auto registe when storage start up #3548

merged 2 commits into from
Dec 29, 2021

Conversation

darionyaphet
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

critical27
critical27 reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reuse the old parameter name hosts_whitelist_enabled

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Dec 23, 2021
jievince
jievince previously approved these changes Dec 23, 2021
View reviewed changes
@darionyaphet darionyaphet force-pushed the auto-register branch 2 times, most recently from bba5127 to 3af8b80 Compare December 23, 2021 09:56
@yixinglu yixinglu merged commit 6849383 into vesoft-inc:master Dec 29, 2021
@Shylock-Hg Shylock-Hg mentioned this pull request Dec 29, 2021
Merged
@darionyaphet darionyaphet deleted the auto-register branch December 29, 2021 06:16
critical27 added a commit that referenced this pull request Dec 29, 2021
@critical27
Revert "Support auto regist (#3548)"
b6e993b 
This reverts commit 6849383.
@critical27 critical27 mentioned this pull request Dec 29, 2021
Merged
critical27 added a commit that referenced this pull request Dec 29, 2021
@critical27 @yixinglu
Revert "Support auto regist (#3548)" (#3592)
6dd7446 
This reverts commit 6849383.

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@jievince jievince jievince approved these changes

@critical27 critical27 Awaiting requested review from critical27

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@darionyaphet @critical27 @Shylock-Hg @jievince @panda-sheep @yixinglu @Sophie-Xie