Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique ID: UUID #3453

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Unique ID: UUID #3453

merged 6 commits into from
Feb 8, 2022

Conversation

jackwener
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Add UUID

Which issue(s)/PR(s) this PR relates to?

close #3452

Special notes for your reviewer, ex. impact of this fix, etc:

None

Additional context:

None

Checklist：

  • Documentation affected （Please add the label if documentation needs to be modified.)
  • Incompatible （If it is incompatible, please describe it and add corresponding label.）
  • Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes：

Please confirm whether to reflect in release notes and how to describe:

@jackwener jackwener self-assigned this Dec 13, 2021
@jackwener jackwener added the ready-for-testing PR: ready for the CI test label Dec 13, 2021
Shylock-Hg
Shylock-Hg reviewed Dec 16, 2021
View reviewed changes
src/common/id/UUID.h Outdated Show resolved Hide resolved
jievince
jievince reviewed Jan 12, 2022
View reviewed changes
src/common/id/UUID.h Outdated Show resolved Hide resolved
src/common/id/UUID.h Show resolved Hide resolved
@jackwener jackwener linked an issue Jan 13, 2022 that may be closed by this pull request
Auto-generated globally unique vertex id #3127
Closed
@jackwener
Copy link
Contributor Author

The reason why the v4 implementation of boost is used is because v1 v3 v5 have security issues and are deprecated.
v2 is basically rarely used.

@jackwener
Copy link
Contributor Author

The probability of conflict has been explained in the note, see the Wikipedia link in the note for details

@jackwener jackwener removed their assignment Jan 18, 2022
@yixinglu yixinglu merged commit 46a4cad into vesoft-inc:master Feb 8, 2022
@jackwener jackwener deleted the uuid branch February 11, 2022 07:15
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 12, 2022
Closed
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request Feb 15, 2022
@jackwener @liwenhui-soul
Unique ID: UUID (vesoft-inc#3453)
c15518e 
* uuid

* uuid
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Feb 22, 2022
@jackwener jackwener removed the doc affected PR: improvements or additions to documentation label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@CPWstatic CPWstatic CPWstatic approved these changes

@jievince jievince jievince approved these changes

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUID Auto-generated globally unique vertex id
6 participants
@jackwener @CPWstatic @Shylock-Hg @jievince @yixinglu @Sophie-Xie