Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crush caused by OptimizeTagIndexScanByFilterRule #3525

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 21, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fix crash caused by filter stated in #3524

Which issue(s)/PR(s) this PR relates to?

Close #3524

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Aiee Aiee added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Dec 21, 2021
@Aiee Aiee changed the title Fix logic in OptimizeTagIndexScanByFilterRule::transform() Fix crush caused by OptimizeTagIndexScanByFilterRule Dec 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3525 (21ad29e) into master (53b85dc) will decrease coverage by 0.01%.
The diff coverage is 77.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3525      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.02%     
==========================================
  Files        1306     1307       +1     
  Lines      122158   122248      +90     
==========================================
+ Hits       104078   104140      +62     
- Misses      18080    18108      +28     
Impacted Files Coverage Δ
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
...mizer/rule/PushLimitDownEdgeIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
...raph/optimizer/rule/PushLimitDownIndexScanRule.cpp 14.81% <0.00%> (-0.57%) ⬇️
...imizer/rule/PushLimitDownTagIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
src/graph/planner/plan/Query.h 97.22% <ø> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f761fa1...21ad29e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lookup bug
4 participants