Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scan limit error more friendly. #3549

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 23, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Close #3492

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 23, 2021
@Shylock-Hg Shylock-Hg added this to the v3.0.0 milestone Dec 23, 2021
@czpmango
Copy link
Contributor

Why do we need this limitation on vertex/edge scans when we already have slow query management?

When executing query:
"""
MATCH (v:player{age:23}:bachelor) RETURN v
"""
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number.
Then a ExecutionError should be raised at runtime: Scan vertices or edges need to specify a limit number, or limit number can not push down.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These error messages are really not friendly and are implementation-specific.

@wey-gu
Copy link
Contributor

wey-gu commented Dec 25, 2021

It seems this scan limit error now overrides the index not existed case, which is not expected if I understand it correctly. update: Aha, now I understand that we introduced scan and enforced user to give a limit filter(for pushdown). ;) Thanks, this is a big move in UX!

(root@nebula) [amundsen]> MATCH (table_node:Table) return count(table_node) as number_of_tables
[ERROR (-1005)]: Scan vertices must specify limit number.

Sat, 25 Dec 2021 19:30:03 CST

(root@nebula) [amundsen]> CREATE TAG INDEX Table_index on Table();
Execution succeeded (time spent 2003/26690 us)

Sat, 25 Dec 2021 19:32:36 CST

(root@nebula) [amundsen]> REBUILD TAG INDEX Table_index
+------------+
| New Job Id |
+------------+
| 4          |
+------------+
Got 1 rows (time spent 3182/18671 us)

Sat, 25 Dec 2021 19:32:59 CST

(root@nebula) [amundsen]> MATCH (table_node:Table) return count(table_node) as number_of_tables
+------------------+
| number_of_tables |
+------------------+
| 6                |
+------------------+

@Shylock-Hg
Copy link
Contributor Author

Why do we need this limitation on vertex/edge scans when we already have slow query management?

According to @CPWstatic 's suggestion, avoid user's mistake.

yixinglu
yixinglu previously approved these changes Dec 27, 2021
czpmango
czpmango previously approved these changes Dec 27, 2021
@yixinglu yixinglu merged commit 2a4be17 into vesoft-inc:master Dec 28, 2021
@Shylock-Hg Shylock-Hg deleted the enhancement/error-msg-more-friendly branch February 9, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error msg of matching on vertex properties
6 participants