[kvstore] adjust log level and add header comments #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
wenhaocs,
cangfengzhs,
liwenhui-soul,
liuyu85cn,
panda-sheep,
SuperYoko and
pengweisong
| @@ -107,7 +107,7 @@ bool RowReaderWrapper::reset(meta::SchemaProviderIf const* schema, | |||
| currReader_ = &readerV2_; | |||
| return true; | |||
| } else { | |||
| LOG(ERROR) << "Unsupported row reader version " << readerVer; | |||
| LOG(WARNING) << "Unsupported row reader version " << readerVer; | |||
There was a problem hiding this comment.
How to distinguish between warning and error？
There was a problem hiding this comment.
It depends on whether administrator need to be involved. ERROR definitely need to be checked, but WARNING is not mandatory.
wenhaocs
previously approved these changes
Jan 28, 2022
wenhaocs
approved these changes
Jan 28, 2022
liuyu85cn
reviewed
Jan 29, 2022
| class RaftLogIterator final : public LogIterator { | ||
| public: | ||
| /** | ||
| * @brief Construct a new raf log iterator |
liuyu85cn
reviewed
Jan 29, 2022
liuyu85cn
approved these changes
Jan 29, 2022
liwenhui-soul
pushed a commit
to liwenhui-soul/nebula
that referenced
this pull request
Feb 15, 2022
* adjust log level * add header comments * address comments * address @wenhaocs's comments * rebased, code format confirm with critical27
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
…esoft-inc#598) * adjust log level * add header comments * address comments * address @wenhaocs's comments * rebased, code format confirm with critical27 Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
src/codecandsrc/kvstoredirectoryAtomicLogBufferto source fileHow do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
If any interface's comments is not clear, feel free to ask me to add some description
Checklist:
Tests:
Affects:
Release notes:
No