Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more table in meta dump #3870

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

pengweisong
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Add the newly added tables in meta when dump.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@pengweisong pengweisong added the ready-for-testing PR: ready for the CI test label Feb 9, 2022
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, since you replace the literal string prefix with the one MetaKeyUtils (I can't remember why I use literal at the first one), maybe you could replace all of them~

@pengweisong
Copy link
Contributor Author

@critical27 The rest prefix did not have corresponding prefix function in MetaKeyUtils.cpp. Is it OK to add extra functions for this? If it's OK, I'll add them.

@critical27
Copy link
Contributor

@critical27 The rest prefix did not have corresponding prefix function in MetaKeyUtils.cpp. Is it OK to add extra functions for this? If it's OK, I'll add them.

Ah, I understand. It is ok to me

critical27
critical27 previously approved these changes Mar 3, 2022
@critical27
Copy link
Contributor

Good job

SuperYoko
SuperYoko previously approved these changes Mar 3, 2022
@HarrisChu
Copy link
Contributor

just curious, could we move "meta_version" to table, and also dump it?

@pengweisong
Copy link
Contributor Author

@HarrisChu meta version is indeed in meta table, I could add it if you need.

@pengweisong pengweisong dismissed stale reviews from SuperYoko and critical27 via a8b2fcf March 7, 2022 10:19
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@critical27 critical27 merged commit 3d105f2 into vesoft-inc:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants