Fix service crash caused by using function call as a part of the filter in LOOKUP
#4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
added
ready-for-testing
Aiee
requested review from
CPWstatic and
jievince
and removed request for
CPWstatic
jievince
approved these changes
Apr 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
- Coverage 85.10% 85.03% -0.07%
==========================================
Files 1339 1324 -15
Lines 132245 131689 -556
==========================================
- Hits 112544 111988 -556
Misses 19701 19701
Continue to review full report at Codecov.
|
Sophie-Xie
pushed a commit
that referenced
this pull request
Apr 3, 2022
…er in `LOOKUP` (#4111) * Fix function call purity check * Add UT for purity check * Add TCK cases
CPWstatic
added a commit
that referenced
this pull request
Apr 3, 2022
* fix memory leak (#4103) * Param MATCH vid seek fix (#4024) * Add qctx to isEvaluableExpr for kRelIn Fixing MATCH (n) WHERE id(n) IN [$t] RETURN n * Fix eq kVal parameter vidseek * Fix id(n) IN [$var] case * lint add explicit and remove tailing semicolon * clang-format-10 * double check type of rightListValue Addressing Kyle's review comment * ut added in features/yield/parameter.feature * support kAttribute match (n) where n in $list_var return n * Add kSubscript for eq case MATCH (v) WHERE id(v) == $p7.a.b.d[4] RETURN v Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> * disable console pkg (#4110) * disable console pkg * fix * disable console pkg (#4112) * Fix service crash caused by using function call as a part of the filter in `LOOKUP` (#4111) * Fix function call purity check * Add UT for purity check * Add TCK cases * Fix cmake command error (#4114) Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: Wey Gu <weyl.gu@gmail.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4097
Description:
There is a bug in the constant folding of function call expressions like
date('2022-03-25')when checking purity.How do you solve it?
Fix purity checking by bonding purity to the number of arity of the function
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: