Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input vid format #4583

Merged
merged 15 commits into from
Aug 30, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Aug 26, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

1、change the data structure of vids in getNeighbor from dataset to vector
2、 fix rewriteVertexEdge2EdgeProp

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 force-pushed the change_input_vid_format branch 4 times, most recently from 8f8aff6 to 29e8abc Compare August 28, 2022 16:59
@nevermore3 nevermore3 marked this pull request as ready for review August 30, 2022 06:04
@nevermore3 nevermore3 requested a review from a team as a code owner August 30, 2022 06:04
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test priority/hi-pri Priority: high ready for review labels Aug 30, 2022
@nevermore3 nevermore3 added this to the v3.3.0 milestone Aug 30, 2022
@@ -66,34 +66,18 @@ Feature: single shortestPath
| <("Blake Griffin" :player{age: 30, name: "Blake Griffin"})-[:like@0 {likeness: -1}]->("Chris Paul" :player{age: 33, name: "Chris Paul"})-[:like@0 {likeness: 90}]->("LeBron James" :player{age: 34, name: "LeBron James"})> |
When executing query:
"""
MATCH p = shortestPath( (a:player{age:30})-[e*..5]->(b:team) ) RETURN p
MATCH p = shortestPath( (a:player{age:30})-[e*..5]->(b:team) ) WHERE id(a) != 'Blake Griffin' RETURN p
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortest path will randomly select a result to return, the result is uncertain, so modify the result

Shylock-Hg
Shylock-Hg previously approved these changes Aug 30, 2022
@nevermore3 nevermore3 mentioned this pull request Aug 30, 2022
11 tasks
@nevermore3 nevermore3 requested a review from dutor August 30, 2022 06:42
dutor
dutor previously approved these changes Aug 30, 2022
@Sophie-Xie Sophie-Xie merged commit db8b909 into vesoft-inc:master Aug 30, 2022
@nevermore3 nevermore3 deleted the change_input_vid_format branch September 2, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants