change time point calculate in ttl #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
previously approved these changes
Sep 28, 2022
critical27
previously approved these changes
Sep 28, 2022
Codecov ReportBase: 84.69% // Head: 84.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4683 +/- ##
==========================================
+ Coverage 84.69% 84.73% +0.04%
==========================================
Files 1358 1358
Lines 135674 135801 +127
==========================================
+ Hits 114911 115077 +166
+ Misses 20763 20724 -39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@shanlai Tell me if you have verified it~ |
pengweisong
dismissed stale reviews from critical27 and panda-sheep
via
ad0a5a4
critical27
previously approved these changes
Oct 9, 2022
pengweisong
dismissed stale reviews from panda-sheep and critical27
via
88eb042
panda-sheep
approved these changes
Oct 9, 2022
critical27
approved these changes
Oct 9, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Oct 9, 2022
* change time point calculate in ttl * fix ttl test * enlarge the ttl sleep interval in the test * fix ttl in index * Revert "enlarge the ttl sleep interval in the test" This reverts commit e37bf51. * change wall time in mock data Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
critical27
pushed a commit
that referenced
this pull request
Oct 12, 2022
* optimize for the last step of go n steps plan (#4690) * optimize for the last step of go n steps plan * improve some comments * change time point calculate in ttl (#4683) * change time point calculate in ttl * fix ttl test * enlarge the ttl sleep interval in the test * fix ttl in index * Revert "enlarge the ttl sleep interval in the test" This reverts commit e37bf51. * change wall time in mock data Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix graph crash (#4698) * fix_ambiguous_case (#4701) * fix_ambiguous_case * change in any order to in order' * fix map hash method (#4707) Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
|
@critical27 Verification passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
When insert ttl field with now() which is calculated by time(NULL). When check if the ttl field valid, we use time::WallClock before, which will drift from time(NULL) with time going.
How do you solve it?
both use time(NULL)
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: