optimize for the last step of go n steps plan #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.69% // Head: 84.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4690 +/- ##
==========================================
+ Coverage 84.69% 84.72% +0.03%
==========================================
Files 1358 1358
Lines 135674 135833 +159
==========================================
+ Hits 114911 115091 +180
+ Misses 20763 20742 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jievince
requested review from
Shylock-Hg,
dutor,
nevermore3,
czpmango and
Aiee
|
Can we do it in optimizer? |
It's very hard to do it in the optimizer. |
nevermore3
previously approved these changes
Oct 8, 2022
czpmango
reviewed
Oct 8, 2022
czpmango
reviewed
Oct 8, 2022
czpmango
reviewed
Oct 8, 2022
czpmango
previously approved these changes
Oct 8, 2022
dutor
reviewed
Oct 8, 2022
Comment on lines
96
to
97
| // Optimize for some simple go sentence which only need dst id. | ||
| // eg. GO 1 TO N STEPS FROM "A" OVER like YIELD DISTINCT like._dst |
jievince
force-pushed
the
optimize-go-last-step
branch
from
0a91715
to
e3a80d5
Compare
nevermore3
approved these changes
Oct 8, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 8, 2022
* optimize for the last step of go n steps plan * improve some comments
critical27
pushed a commit
that referenced
this pull request
Oct 12, 2022
* optimize for the last step of go n steps plan (#4690) * optimize for the last step of go n steps plan * improve some comments * change time point calculate in ttl (#4683) * change time point calculate in ttl * fix ttl test * enlarge the ttl sleep interval in the test * fix ttl in index * Revert "enlarge the ttl sleep interval in the test" This reverts commit e37bf51. * change wall time in mock data Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix graph crash (#4698) * fix_ambiguous_case (#4701) * fix_ambiguous_case * change in any order to in order' * fix map hash method (#4707) Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Optimize the last step of go n steps plan.
In the following query, the where clause only uses dst tag props, so we still can replace the last
GetneightborswithGetDstbySrc.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: