forbid insert vertex when vertex_key flag is off #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
added
ready-for-testing
|
Don't merge yet, there is another tagless related issue |
|
Ready to review now |
Shylock-Hg
reviewed
Oct 14, 2022
| @@ -394,21 +394,18 @@ Feature: TTLTest | |||
| """ | |||
| Then the result should be, in any order, with relax comparison: | |||
| | node | | |||
| | ("1") | | |||
There was a problem hiding this comment.
Why got empty set when vertex inserted.
There was a problem hiding this comment.
It has ttl column, and ttl expired
Shylock-Hg
approved these changes
Oct 17, 2022
nevermore3
approved these changes
Oct 17, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Oct 17, 2022
* forbid insert vertex when vertex_key flag is off * fix issue ent#1420 * fix test case * fix format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
critical27
added a commit
that referenced
this pull request
Oct 17, 2022
* Fix aggregate expression type deduce (#4706) * fix aggregate expression type deduce add test case fix tck fix tck * fix ut * fix hdfs download command will always return succeeded (#4723) * remove rebuild index guard when job finished (#4722) * remove rebuild index guard when job finished * fix reenter problem Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * split experimental_feature flag (#4728) * split experimental_feature flag * eof * forbid insert vertex when vertex_key flag is off (#4727) * forbid insert vertex when vertex_key flag is off * fix issue ent#1420 * fix test case * fix format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
As title, when vertex_key is not used, we forbid it. Otherwise, it will report succeeded, but no data is inserted.
Fix https://github.com/vesoft-inc/nebula-ent/issues/1420, it seems we can't simply prefix scan, we need to check if any tag is valid indeed. And valid means: tag schema exists and no ttl expired.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: