Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split experimental_feature flag #4728

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Oct 14, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4729

Description:

experimental flags control toss and data balance at the same time.

How do you solve it?

add 2 sub flag, current config only allow data balance.

# if use experimental features
--enable_experimental_feature=false
# if use toss feature, only work if enable_experimental_feature is true
--enable_toss=false
# if use balance data feature, only work if enable_experimental_feature is true
--enable_data_balance=true

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

add new flag to support only open toss(not suggest)/ data balance feature

@SuperYoko SuperYoko requested a review from a team as a code owner October 14, 2022 07:52
@panda-sheep
Copy link
Contributor

Efficient

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Oct 14, 2022
@wey-gu
Copy link
Contributor

wey-gu commented Oct 15, 2022

I created the issue before realizing your pr 🙃.

The issue was aligned with @MuYiYong already.

Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@critical27 critical27 merged commit ee38052 into vesoft-inc:master Oct 17, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 17, 2022
Sophie-Xie pushed a commit that referenced this pull request Oct 17, 2022
* split experimental_feature flag

* eof
critical27 added a commit that referenced this pull request Oct 17, 2022
* Fix aggregate expression type deduce (#4706)

* fix aggregate expression type deduce

add test case

fix tck

fix tck

* fix ut

* fix hdfs download command will always return succeeded (#4723)

* remove rebuild index guard when job finished (#4722)

* remove rebuild index guard when job finished

* fix reenter problem

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* split experimental_feature flag (#4728)

* split experimental_feature flag

* eof

* forbid insert vertex when vertex_key flag is off (#4727)

* forbid insert vertex when vertex_key flag is off

* fix issue ent#1420

* fix test case

* fix format

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Oct 17, 2022
@foesa-yang foesa-yang added doc done PR:the doc for this PR is done. and removed doc affected PR: improvements or additions to documentation labels Oct 20, 2022
@jinyingsunny
Copy link

cr了代码,没做验证

@SuperYoko SuperYoko deleted the add_toss_flag branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version doc done PR:the doc for this PR is done. ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants