Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter should keep column names. #4825

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Nov 4, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Of https://github.com/vesoft-inc/nebula-ent/issues/1569

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected cherry-pick-v3.3 PR: need cherry-pick to this version labels Nov 4, 2022
@Aiee
Copy link
Contributor

Aiee commented Nov 4, 2022

Please add the case to the test.
Maybe you should close the PR in the ent version and sync this PR to the ent edition.

@Shylock-Hg
Copy link
Contributor Author

Please add the case to the test. Maybe you should close the PR in the ent version and sync this PR to the ent edition.

https://github.com/vesoft-inc/nebula-ent/pull/1572

@Sophie-Xie Sophie-Xie merged commit e96774e into vesoft-inc:master Nov 7, 2022
@Shylock-Hg Shylock-Hg deleted the fix/filter-should-keep-column-names branch November 7, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants