Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support add listener in tck #5006

Merged
merged 9 commits into from
Dec 19, 2022
Merged

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 77.24% // Head: 77.28% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (53d8b0c) compared to base (5b5a49b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
+ Coverage   77.24%   77.28%   +0.04%     
==========================================
  Files        1105     1105              
  Lines       82120    82133      +13     
==========================================
+ Hits        63434    63477      +43     
+ Misses      18686    18656      -30     
Impacted Files Coverage Δ
src/graph/context/Result.cpp 70.00% <0.00%> (-7.78%) ⬇️
src/graph/executor/StorageAccessExecutor.h 54.54% <0.00%> (-2.28%) ⬇️
src/graph/service/PermissionCheck.cpp 79.59% <0.00%> (-2.05%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.64%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 81.25% <0.00%> (-1.05%) ⬇️
src/codec/RowReaderWrapper.cpp 78.57% <0.00%> (-0.82%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 79.00% <0.00%> (-0.77%) ⬇️
src/common/fs/FileUtils.cpp 73.66% <0.00%> (-0.66%) ⬇️
src/kvstore/raftex/RaftPart.cpp 69.61% <0.00%> (-0.65%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cangfengzhs cangfengzhs changed the title support add listeener in tck support add listener in tck Dec 7, 2022
@critical27 critical27 merged commit fd46ba9 into vesoft-inc:master Dec 19, 2022
yixinglu added a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* support add listeener in tck

* add ft index test demo in tck

* fmt

* fix standalone

* fix standalone

* fix standalone

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants