Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tck of kill-query #5025

Merged
merged 7 commits into from
Dec 27, 2022
Merged

Conversation

caton-hpg
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

@Sophie-Xie Sophie-Xie requested a review from Aiee December 9, 2022 02:30
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Dec 9, 2022
@yixinglu
Copy link
Contributor

@caton-hpg could you fix the lint error and CI ?

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Base: 77.34% // Head: 77.40% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (e95df9a) compared to base (70d0bb2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
+ Coverage   77.34%   77.40%   +0.05%     
==========================================
  Files        1105     1105              
  Lines       82146    82148       +2     
==========================================
+ Hits        63539    63587      +48     
+ Misses      18607    18561      -46     
Impacted Files Coverage Δ
...rc/meta/processors/config/ListConfigsProcessor.cpp 75.00% <0.00%> (-20.84%) ⬇️
src/meta/processors/BaseProcessor.h 76.92% <0.00%> (-15.39%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/common/base/Status.cpp 60.75% <0.00%> (-2.54%) ⬇️
...c/meta/processors/user/AuthenticationProcessor.cpp 87.35% <0.00%> (-1.92%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.69%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
src/kvstore/raftex/RaftPart.cpp 69.91% <0.00%> (-0.94%) ⬇️
src/common/utils/IndexKeyUtils.h 92.07% <0.00%> (-0.88%) ⬇️
src/graph/optimizer/Optimizer.cpp 92.00% <0.00%> (-0.80%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1,101 @@
# Copyright (c) 2021 vesoft inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the case mentioned in the comment above.

@Sophie-Xie Sophie-Xie merged commit f8935e0 into vesoft-inc:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants