Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/permission #5058

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Test/permission #5058

merged 5 commits into from
Dec 21, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Sub job of https://github.com/vesoft-inc/nebula-ent/issues/1754

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.38% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (81e628b) compared to base (cc0ce34).
Patch coverage: 82.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5058      +/-   ##
==========================================
+ Coverage   77.24%   77.38%   +0.13%     
==========================================
  Files        1105     1105              
  Lines       82054    82127      +73     
==========================================
+ Hits        63383    63553     +170     
+ Misses      18671    18574      -97     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 75.95% <0.00%> (-0.60%) ⬇️
src/clients/storage/StorageClientBase-inl.h 76.71% <0.00%> (ø)
src/graph/executor/StorageAccessExecutor.h 54.54% <0.00%> (-3.60%) ⬇️
src/graph/executor/admin/ShowHostsExecutor.cpp 93.54% <ø> (+0.99%) ⬆️
src/graph/executor/query/ProjectExecutor.cpp 61.11% <ø> (-2.78%) ⬇️
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/meta/processors/BaseProcessor.h 76.92% <ø> (ø)
src/graph/service/QueryInstance.cpp 80.13% <50.00%> (-0.56%) ⬇️
src/graph/validator/MatchValidator.cpp 89.51% <75.00%> (-0.08%) ⬇️
src/graph/executor/query/TraverseExecutor.cpp 84.90% <82.06%> (+16.88%) ⬆️
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 70d0bb2 into vesoft-inc:master Dec 21, 2022
@Shylock-Hg Shylock-Hg deleted the test/permission branch December 21, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants