Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong vid finder for logic or expr #5062

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #5063, Fix https://github.com/vesoft-inc/nebula-ent/issues/1530
Fix #5067

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince marked this pull request as ready for review December 15, 2022 13:31
@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 15, 2022
yixinglu
yixinglu previously approved these changes Dec 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Base: 76.96% // Head: 77.83% // Increases project coverage by +0.87% 🎉

Coverage data is based on head (296fd10) compared to base (8e7aa68).
Patch coverage: 95.91% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5062      +/-   ##
==========================================
+ Coverage   76.96%   77.83%   +0.87%     
==========================================
  Files        1108     1108              
  Lines       82405    82454      +49     
==========================================
+ Hits        63425    64181     +756     
+ Misses      18980    18273     -707     
Impacted Files Coverage Δ
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/graph/util/ExpressionUtils.cpp 94.25% <94.11%> (-0.02%) ⬇️
src/graph/visitor/VidExtractVisitor.cpp 49.70% <100.00%> (-0.59%) ⬇️
src/graph/executor/query/TraverseExecutor.h 90.00% <0.00%> (-6.43%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/graph/executor/StorageAccessExecutor.h 56.81% <0.00%> (-2.28%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 79.77% <0.00%> (-1.91%) ⬇️
src/graph/executor/query/ProjectExecutor.cpp 61.11% <0.00%> (-1.75%) ⬇️
src/codec/RowReaderWrapper.h 95.08% <0.00%> (-1.64%) ⬇️
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jievince jievince force-pushed the wrong-vid-finder branch 5 times, most recently from acf0fd2 to 23f4893 Compare December 23, 2022 03:07
xtcyclist
xtcyclist previously approved these changes Dec 23, 2022
src/graph/util/ExpressionUtils.cpp Outdated Show resolved Hide resolved
src/graph/util/ExpressionUtils.cpp Outdated Show resolved Hide resolved
src/graph/util/ExpressionUtils.cpp Outdated Show resolved Hide resolved
src/graph/util/ExpressionUtils.cpp Show resolved Hide resolved
yixinglu
yixinglu previously approved these changes Dec 23, 2022
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Aiee
Aiee previously approved these changes Dec 26, 2022
@Sophie-Xie Sophie-Xie merged commit 82184aa into vesoft-inc:master Dec 26, 2022
@jievince jievince deleted the wrong-vid-finder branch December 26, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical expression simplification Incorrect match query result
8 participants