Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notes for the default charset and collation in the default conf… #5066

Closed
wants to merge 1 commit into from

Conversation

xtcyclist
Copy link
Contributor

…ig file.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/1934
Close #5065

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 77.32% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (1834aa4) compared to base (cc0ce34).
Patch coverage: 83.48% of modified lines in pull request are covered.

❗ Current head 1834aa4 differs from pull request most recent head 57782f2. Consider uploading reports for the commit 57782f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5066      +/-   ##
==========================================
+ Coverage   77.24%   77.32%   +0.08%     
==========================================
  Files        1105     1105              
  Lines       82054    82137      +83     
==========================================
+ Hits        63383    63515     +132     
+ Misses      18671    18622      -49     
Impacted Files Coverage Δ
src/graph/executor/admin/ShowHostsExecutor.cpp 93.54% <ø> (+0.99%) ⬆️
src/graph/executor/query/ProjectExecutor.cpp 61.11% <ø> (-2.78%) ⬇️
src/graph/optimizer/Optimizer.h 100.00% <ø> (ø)
src/graph/service/QueryInstance.cpp 80.13% <50.00%> (-0.56%) ⬇️
src/graph/validator/MatchValidator.cpp 89.51% <75.00%> (-0.08%) ⬇️
src/graph/executor/query/TraverseExecutor.cpp 84.90% <82.06%> (+16.88%) ⬆️
src/graph/executor/query/TraverseExecutor.h 90.00% <86.95%> (-10.00%) ⬇️
src/graph/optimizer/Optimizer.cpp 92.80% <95.00%> (+0.76%) ⬆️
src/common/expression/PropertyExpression.cpp 92.41% <100.00%> (+0.44%) ⬆️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xtcyclist xtcyclist closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph'sdefault_charset & default_collate configuration invalid
3 participants