Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of reduce unary not for logic xor #5091

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 22, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #5090, Fix https://github.com/vesoft-inc/nebula-ent/issues/1818
NOT((NOT true) XOR true)) shouldn't be rewritten to true XOR false. They are not equivalent.

By the way, fixed #5089

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince marked this pull request as ready for review December 22, 2022 05:38
@jievince jievince added ready-for-testing PR: ready for the CI test ready for review and removed ready for review labels Dec 22, 2022
Aiee
Aiee previously approved these changes Dec 22, 2022
yixinglu
yixinglu previously approved these changes Dec 22, 2022
@jievince jievince requested a review from Aiee December 23, 2022 02:35
@jievince jievince dismissed stale reviews from yixinglu and Aiee via 93b4ca0 December 23, 2022 07:44
@vesoft-inc vesoft-inc deleted a comment from Aiee Dec 23, 2022
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Sophie-Xie Sophie-Xie merged commit 9863ff0 into vesoft-inc:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect match query result(2) Forget to handle Logical Xor expr
4 participants