Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-prop tck #5103

Merged
merged 3 commits into from
Dec 27, 2022
Merged

fetch-prop tck #5103

merged 3 commits into from
Dec 27, 2022

Conversation

caton-hpg
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Base: 77.36% // Head: 77.86% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (aea2874) compared to base (011f2fa).
Patch coverage: 74.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5103      +/-   ##
==========================================
+ Coverage   77.36%   77.86%   +0.49%     
==========================================
  Files        1105     1108       +3     
  Lines       82188    82412     +224     
==========================================
+ Hits        63586    64168     +582     
+ Misses      18602    18244     -358     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/common/meta/SchemaManager.h 50.00% <ø> (ø)
src/common/meta/ServerBasedSchemaManager.h 100.00% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 91.17% <ø> (+4.68%) ⬆️
src/graph/optimizer/OptimizerUtils.cpp 94.82% <ø> (-0.03%) ⬇️
src/graph/optimizer/rule/IndexScanRule.cpp 88.13% <ø> (+0.11%) ⬆️
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
src/graph/planner/plan/PlanNode.h 89.42% <ø> (ø)
src/graph/planner/plan/Query.cpp 71.30% <0.00%> (-0.89%) ⬇️
src/graph/planner/plan/Scan.h 100.00% <ø> (ø)
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

xtcyclist
xtcyclist previously approved these changes Dec 23, 2022
@Sophie-Xie Sophie-Xie merged commit ab790b1 into vesoft-inc:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants