Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/user #5139

Merged
merged 15 commits into from
Jan 29, 2023
Merged

Test/user #5139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
12d3b55
Add some tests about user management.
Shylock-Hg Dec 27, 2022
c36b23a
Add tests about user roles.
Shylock-Hg Dec 28, 2022
6ceb34e
Merge branch 'master' into test/user
Shylock-Hg Dec 28, 2022
f876d39
Format.
Shylock-Hg Dec 30, 2022
edc6512
Merge branch 'master' into test/user
Shylock-Hg Dec 30, 2022
bca56d8
Fix tck fixture name.
Shylock-Hg Jan 3, 2023
4979863
Merge branch 'master' into test/user
Shylock-Hg Jan 3, 2023
80c1374
Merge branch 'master' into test/user
Sophie-Xie Jan 4, 2023
e1e0eb4
Fix step name.
Shylock-Hg Jan 10, 2023
c1033df
Merge branch 'master' into test/user
Shylock-Hg Jan 10, 2023
7a9d8ff
Merge branch 'master' into test/user
Shylock-Hg Jan 10, 2023
8cacc86
Merge branch 'master' into test/user
Shylock-Hg Jan 17, 2023
960d9a8
Change step name.
Shylock-Hg Jan 17, 2023
7bc991e
Merge branch 'master' into test/user
Sophie-Xie Jan 19, 2023
ff245ea
Merge branch 'master' into test/user
Sophie-Xie Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/tck/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,3 +980,19 @@ def switch_to_new_session(conn_pool, user, password, class_fixture_variables, ex
sess = conn_pool.get_session(user, password)
class_fixture_variables["sessions"].append(sess)
exec_ctx["current_session"] = sess

@when(parse('verify login with user "{user}"'))
def login_without_password(conn_pool, user):
sess = None
try:
sess = conn_pool.get_session(user, '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to reset the current_session in exec_ctx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verify logging, avoid affecting other tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't change the current session, how do you make sure the next test cases use the current login user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next test will use origin session.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if so, does this step just test whether the user exists? why not to use show users to test it? if you want to switch user and test role, plz consider to switch the current session.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be logged in by this user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test login feature? what to do after the user login? I don't find where to use the login user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test login.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to test this feature in role cases ? such as:

When executing query:
  """
  create user username...
  grant user some rule ..
  """
Then executing successfully
When switch to new session with user "{user}" and password "{password}"
Then executing successfully
When executing query:
  """
   test role of user
  """
Then ...

it's not necessary to create a new step for this feature and we have the related step for switching user:

switch to new session with user "{user}" and password "{password}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to change current session.

except Exception as e:
assert e

@when(parse('verify login with user "{user}" and password "{password}"'))
def login_with_password(conn_pool, user, password):
sess = None
try:
sess = conn_pool.get_session(user, password)
except Exception as e:
assert e
Loading