Test/user

[Shylock-Hg]

What type of PR is this?

• bug
• feature
• enhancement

What problem(s) does this PR solve?

Issue(s) number:

Sub job about https://github.com/vesoft-inc/nebula-ent/issues/1754

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

• Unit test(positive and negative cases)
• Function test
• Performance test
• N/A

Affects:

• Documentation affected (Please add the label if documentation needs to be modified.)
• Incompatibility (If it breaks the compatibility, please describe it and add the label.）
• If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
• Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

[yixinglu]

why not to reset the current_session in exec_ctx?

[Shylock-Hg]

Just verify logging, avoid affecting other tests.

[yixinglu]

if you don't change the current session, how do you make sure the next test cases use the current login user?

[Shylock-Hg]

Next test will use origin session.

[yixinglu]

if so, does this step just test whether the user exists? why not to use show users to test it? if you want to switch user and test role, plz consider to switch the current session.

[Shylock-Hg]

This will be logged in by this user.

[yixinglu]

Just test login feature? what to do after the user login? I don't find where to use the login user?

[Shylock-Hg]

Just test login.

[yixinglu]

why not to test this feature in role cases ? such as:

When executing query:
  """
  create user username...
  grant user some rule ..
  """
Then executing successfully
When switch to new session with user "{user}" and password "{password}"
Then executing successfully
When executing query:
  """
   test role of user
  """
Then ...

it's not necessary to create a new step for this feature and we have the related step for switching user:

switch to new session with user "{user}" and password "{password}"

[Shylock-Hg]

Don't want to change current session.

[yixinglu]

if you don't change the current session, how do you make sure the next test cases use the current login user?

[codecov-commenter]

Codecov Report

Base: 77.60% // Head: 78.70% // Increases project coverage by +1.09% 🎉

Coverage data is based on head (ff245ea) compared to base (7acdc9f).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5139      +/-   ##
==========================================
+ Coverage   77.60%   78.70%   +1.09%     
==========================================
  Files        1110     1110              
  Lines       83001    82998       -3     
==========================================
+ Hits        64416    65323     +907     
+ Misses      18585    17675     -910     

Impacted Files	Coverage Δ
src/common/memory/NewDelete.cpp	56.25% <0.00%> (-6.25%)	⬇️
src/kvstore/raftex/Host.cpp	72.66% <0.00%> (-3.54%)	⬇️
src/common/memory/Memory.h	82.92% <0.00%> (-2.44%)	⬇️
src/storage/mutate/AddVerticesProcessor.cpp	86.07% <0.00%> (-2.11%)	⬇️
src/storage/admin/AdminTaskManager.cpp	80.64% <0.00%> (-2.02%)	⬇️
src/codec/RowReaderWrapper.h	95.08% <0.00%> (-1.64%)	⬇️
src/common/process/ProcessUtils.cpp	84.70% <0.00%> (-1.18%)	⬇️
src/common/datatypes/Date.h	94.57% <0.00%> (-0.78%)	⬇️
src/kvstore/wal/AtomicLogBuffer.cpp	96.15% <0.00%> (-0.77%)	⬇️
src/common/network/NetworkUtils.cpp	81.11% <0.00%> (-0.56%)	⬇️
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.