Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta's cleanup not work as expected #5321

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Feb 7, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/2399
Close #5320

Description:

Meta does not clean up all data before receiving snapshot... The bug must have existed for quite a long time...

How do you solve it?

Delete all data by delete range. The code is quite ugly, but I don't think of any better ways...

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

Codecov Report

Base: 77.67% // Head: 78.70% // Increases project coverage by +1.03% 🎉

Coverage data is based on head (9857e57) compared to base (7470a4a).
Patch coverage: 81.42% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5321      +/-   ##
==========================================
+ Coverage   77.67%   78.70%   +1.03%     
==========================================
  Files        1110     1119       +9     
  Lines       83422    83624     +202     
==========================================
+ Hits        64798    65817    +1019     
+ Misses      18624    17807     -817     
Impacted Files Coverage Δ
src/common/datatypes/Value.h 97.05% <ø> (ø)
src/graph/context/iterator/GetNeighborsIter.cpp 87.14% <ø> (ø)
src/graph/executor/query/TraverseExecutor.h 100.00% <ø> (+10.34%) ⬆️
src/graph/gc/GC.cpp 0.00% <ø> (ø)
src/kvstore/Part.h 100.00% <ø> (ø)
src/kvstore/Part.cpp 52.54% <14.28%> (-1.28%) ⬇️
src/graph/context/iterator/DefaultIter.h 28.57% <28.57%> (ø)
src/graph/context/iterator/Iterator.cpp 72.00% <72.00%> (ø)
src/graph/context/iterator/PropIter.cpp 72.39% <72.39%> (ø)
src/graph/context/iterator/GetNeighborsIter.h 72.50% <72.50%> (ø)
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... hope that clean up part is not called to many times.

@wenhaocs
Copy link
Contributor

wenhaocs commented Feb 7, 2023

Weird... hope that clean up part is not called to many times.

Will the receiving snapshot happen very often? If not, I think that's fine. Or if it happens very often, the performance and availability will also be impacted even without this cleanup.

@Sophie-Xie Sophie-Xie merged commit c04dc94 into vesoft-inc:master Feb 8, 2023
@critical27 critical27 deleted the fix branch February 8, 2023 01:46
Sophie-Xie pushed a commit that referenced this pull request Feb 9, 2023
Sophie-Xie added a commit that referenced this pull request Feb 9, 2023
* fix meta has not cleanup when reset (#5321)

* support upgrade from V2 to V3.4 (#5319)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix meta update (#5326)

* fix meta update

* fix bug

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

---------

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
@luyade luyade mentioned this pull request Apr 20, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta data inconsistent
5 participants