Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix meta update #5326

Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix meta update #5326

merged 3 commits into from
Feb 9, 2023

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Feb 8, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 77.67% // Head: 78.65% // Increases project coverage by +0.98% 🎉

Coverage data is based on head (d0b87d3) compared to base (7470a4a).
Patch coverage: 72.26% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5326      +/-   ##
==========================================
+ Coverage   77.67%   78.65%   +0.98%     
==========================================
  Files        1110     1119       +9     
  Lines       83422    83695     +273     
==========================================
+ Hits        64798    65831    +1033     
+ Misses      18624    17864     -760     
Impacted Files Coverage Δ
src/common/datatypes/Value.h 97.05% <ø> (ø)
src/graph/context/iterator/GetNeighborsIter.cpp 86.92% <ø> (ø)
src/graph/executor/query/TraverseExecutor.h 100.00% <ø> (+10.34%) ⬆️
src/graph/gc/GC.cpp 0.00% <ø> (ø)
src/kvstore/Part.h 100.00% <ø> (ø)
src/meta/MetaVersionMan.cpp 28.57% <2.53%> (+3.14%) ⬆️
src/daemons/MetaDaemonInit.cpp 58.82% <13.33%> (-2.39%) ⬇️
src/kvstore/Part.cpp 52.83% <14.28%> (-1.00%) ⬇️
src/graph/context/iterator/DefaultIter.h 28.57% <28.57%> (ø)
src/graph/context/iterator/Iterator.cpp 72.00% <72.00%> (ø)
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 merged commit c30f52b into vesoft-inc:master Feb 9, 2023
Sophie-Xie added a commit that referenced this pull request Feb 9, 2023
* fix meta update

* fix bug

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sophie-Xie added a commit that referenced this pull request Feb 9, 2023
* fix meta has not cleanup when reset (#5321)

* support upgrade from V2 to V3.4 (#5319)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix meta update (#5326)

* fix meta update

* fix bug

---------

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

---------

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.4 ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants