Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Speed up the startup of storaged #5521

Merged
merged 7 commits into from
May 9, 2023

Conversation

luyade
Copy link
Contributor

@luyade luyade commented Apr 21, 2023

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

Open the rocksdb engines in parallel to speed up the startup of storaged

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@luyade luyade requested a review from a team as a code owner April 21, 2023 11:01
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Apr 23, 2023
@Sophie-Xie
Copy link
Contributor

Pls fix the CI, thanks.

critical27
critical27 previously approved these changes May 8, 2023
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
src/kvstore/NebulaStore.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~~~ Thx

@Sophie-Xie Sophie-Xie merged commit 5419140 into vesoft-inc:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants