Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ft #5594

Merged
merged 4 commits into from
Jun 14, 2023
Merged

fix ft #5594

merged 4 commits into from
Jun 14, 2023

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Jun 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 43.33% and project coverage change: +0.66 🎉

Comparison is base (b3c5086) 77.02% compared to head (dfd1376) 77.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5594      +/-   ##
==========================================
+ Coverage   77.02%   77.69%   +0.66%     
==========================================
  Files        1130     1130              
  Lines       85289    85320      +31     
==========================================
+ Hits        65696    66290     +594     
+ Misses      19593    19030     -563     
Impacted Files Coverage Δ
...c/common/plugin/fulltext/elasticsearch/ESAdapter.h 28.57% <ø> (+14.28%) ⬆️
src/common/utils/MetaKeyUtils.cpp 84.80% <ø> (+1.54%) ⬆️
...graph/executor/query/FulltextIndexScanExecutor.cpp 0.00% <0.00%> (ø)
src/kvstore/listener/elasticsearch/ESListener.cpp 23.43% <0.00%> (+23.43%) ⬆️
src/kvstore/listener/elasticsearch/ESListener.h 100.00% <ø> (+100.00%) ⬆️
src/meta/processors/index/FTIndexProcessor.cpp 57.83% <25.00%> (+51.04%) ⬆️
src/meta/processors/schema/AlterTagProcessor.cpp 79.82% <73.33%> (+3.03%) ⬆️
...common/plugin/fulltext/elasticsearch/ESAdapter.cpp 68.51% <100.00%> (+1.43%) ⬆️
src/graph/executor/logic/ArgumentExecutor.cpp 95.00% <100.00%> (+0.55%) ⬆️
src/graph/executor/maintain/FTIndexExecutor.cpp 83.78% <100.00%> (+83.78%) ⬆️
... and 2 more

... and 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

critical27
critical27 previously approved these changes Jun 14, 2023
yixinglu
yixinglu previously approved these changes Jun 14, 2023
@Sophie-Xie Sophie-Xie merged commit b59eaf1 into vesoft-inc:master Jun 14, 2023
4 of 5 checks passed
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
* show analyzer when show ft index (vesoft-inc#5587)

* show analyzer when show ft index

* fix tck

* fix ft (vesoft-inc#5594)

* fix conflict

* Fix expression issues when using ES_QUERY in Lookup clause (vesoft-inc#5597)

* Add cherry pick missed codes

* Restore permission check logics

---------

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants