Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression issues when using ES_QUERY in Lookup clause #5597

Merged
merged 13 commits into from
Jun 15, 2023

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jun 14, 2023
@yixinglu yixinglu marked this pull request as ready for review June 14, 2023 16:27
@yixinglu
Copy link
Contributor Author

hold on a minute! some changes maybe committed

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch coverage: 80.16% and project coverage change: +1.15 🎉

Comparison is base (b3c5086) 77.02% compared to head (c496e12) 78.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5597      +/-   ##
==========================================
+ Coverage   77.02%   78.18%   +1.15%     
==========================================
  Files        1130     1130              
  Lines       85289    85351      +62     
==========================================
+ Hits        65696    66732    +1036     
+ Misses      19593    18619     -974     
Impacted Files Coverage Δ
src/common/datatypes/Vertex.h 71.79% <ø> (ø)
...c/common/plugin/fulltext/elasticsearch/ESAdapter.h 100.00% <ø> (+85.71%) ⬆️
src/common/utils/MetaKeyUtils.cpp 84.80% <ø> (+1.54%) ⬆️
src/graph/context/iterator/SequentialIter.h 100.00% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 81.81% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 97.05% <ø> (ø)
src/graph/util/ExpressionUtils.h 100.00% <ø> (ø)
src/kvstore/listener/elasticsearch/ESListener.h 100.00% <ø> (+100.00%) ⬆️
src/meta/processors/index/FTIndexProcessor.cpp 58.43% <25.00%> (+51.64%) ⬆️
...graph/executor/query/FulltextIndexScanExecutor.cpp 65.07% <40.00%> (+65.07%) ⬆️
... and 16 more

... and 69 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 38c8044 into vesoft-inc:master Jun 15, 2023
6 of 9 checks passed
@yixinglu yixinglu deleted the rewrite-expr branch June 15, 2023 08:46
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
* show analyzer when show ft index (vesoft-inc#5587)

* show analyzer when show ft index

* fix tck

* fix ft (vesoft-inc#5594)

* fix conflict

* Fix expression issues when using ES_QUERY in Lookup clause (vesoft-inc#5597)

* Add cherry pick missed codes

* Restore permission check logics

---------

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants