fix a problem when set flags in all module. #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
andychow01,
dangleptr,
darionyaphet and
whitewum
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
critical27
changed the title
critical27
added
in progress
and removed
ready-for-testing
critical27
added
ready-for-testing
|
Unit testing passed. |
critical27
changed the title
whitewum
approved these changes
Aug 9, 2019
First, can we add this TODO into the code? Messages here intend to be lost when the PR is merged |
Yeah, I will open an issue to record. |
|
Unit testing passed. |
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_config_interval_secs(it is used in early implement version), just keep same speed with load_data_interval_secs.TODO: Maybe we will organize all config into a separate file, and avoid hard code, and config manager will load it and try to register on meta.