Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DIVs with inline content #5

Closed
coreyworrell opened this issue Jul 7, 2014 · 3 comments
Closed

Replace DIVs with inline content #5

coreyworrell opened this issue Jul 7, 2014 · 3 comments

Comments

@coreyworrell
Copy link

A select is inline (phrasing) content, and thus a common practice is to place them within p elements. So the select-or-die replacement element should follow this.
vestman pushed a commit that referenced this issue Jul 7, 2014
Fixed issue #4 and #5
3215007 
Changed the markup produced by the SoD to use span’s instead of div’s
and also fixed an issue when focus is changed and no selection has been
made.
@vestman
Copy link
Owner

vestman commented Jul 7, 2014

Good point. Fixed!

@coreyworrell
Copy link
Author

Great! Nice work on this btw 👍

@vestman
Copy link
Owner

vestman commented Jul 7, 2014

Thanks!

@vestman vestman closed this as completed Jul 7, 2014
@vestman vestman mentioned this issue Jul 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coreyworrell @vestman