Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash: unclosed multiline comment inside an unterminated preprocessor conditional #561

Closed
ehaas opened this issue Nov 14, 2023 · 0 comments · Fixed by #563
Closed

Crash: unclosed multiline comment inside an unterminated preprocessor conditional #561

ehaas opened this issue Nov 14, 2023 · 0 comments · Fixed by #563
Labels
bug Something isn't working crash A bug that causes the compiler to crash

Comments

@ehaas
Copy link
Collaborator

ehaas commented Nov 14, 2023 

#if /*

This hits the unreachable prong in Tokenizer.lexeme
@ehaas ehaas added bug Something isn't working crash A bug that causes the compiler to crash labels Nov 14, 2023
ehaas added a commit to ehaas/arocc that referenced this issue Nov 14, 2023
@ehaas
Tokenizer: don't mark unterminated comment lexeme as unreachable
d2a015a 
Fixes Vexu#561
@ehaas ehaas mentioned this issue Nov 14, 2023
Merged
@Vexu Vexu closed this as completed in #563 Nov 14, 2023
Vexu pushed a commit that referenced this issue Nov 14, 2023
@ehaas @Vexu
Tokenizer: don't mark unterminated comment lexeme as unreachable
27dea6b 
Fixes #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working crash A bug that causes the compiler to crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tokenizer: don't mark unterminated comment lexeme as unreachable ehaas/arocc
1 participant
@ehaas