Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdlets1\AboutDiscovery.ps1 #335

Closed
scottone opened this issue Dec 24, 2019 · 1 comment · Fixed by #347
Closed

Cmdlets1\AboutDiscovery.ps1 #335

scottone opened this issue Dec 24, 2019 · 1 comment · Fixed by #347
Assignees
Labels
Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong!

Comments

@scottone
Copy link

Describe "Koan Bug, Issue, or Help Request"

Context "The Problematic Assertions"

It 'can look for commands by module' {
        $KoanCommands = Get-Command -Module 'PSKoans' |
            Sort-Object -Property Name
        $First4Commands = $KoanCommands | Select-Object -First 4

        __ | Should -Be $KoanCommands.Count
        @('__', '____', '____', '____') | Should -Be $KoanCommands.Name
    }

Context "Your Attempts"

The assertion could only pass if there were 4 commands in the PSKoans module.
Correction:
@('__', '____', '____', '____') | Should -Be $First4Commands.Name

Context "Additional Information"

@scottone scottone added Category-Koans Invoking the Great Doubt Issue-Discussion Let's talk about it! labels Dec 24, 2019
@vexx32
Copy link
Owner

vexx32 commented Dec 24, 2019

Whoops, good catch! Feel like we should have seen that one before 😅

@vexx32 vexx32 added Good First Issue ❇️ Should be quick and easy! Hacktoberfest Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. and removed Issue-Discussion Let's talk about it! labels Dec 24, 2019
@vexx32 vexx32 removed Hacktoberfest 💻 Good First Issue ❇️ Should be quick and easy! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. labels Jan 15, 2020
@vexx32 vexx32 self-assigned this Jan 18, 2020
vexx32 added a commit that referenced this issue Jan 18, 2020
vexx32 added a commit that referenced this issue Jan 19, 2020
* 🔧 Resolve issues in AboutModules

Fixes #342

* 🔧 Fix issues in AboutTeeObject

Fixes #341

Also added a new koan to show when the variable is created

* 🔧 Fix issues in AboutMeasureObject

Fixes #340

* 🔧 Fix issues in AboutSelectObject

Fixes #339

Fixes #337

* 🔧 Fix issue in AboutAssignmentAndArithmetic

Fixes #334

* 🔧 Fix issues in AboutDiscovery

Fixes #335

Fixes #332

* 🔧 ♻️ Fix up AboutArrays

Fixes #330

* 🔧 Fix missing variable reference

* 🎨 Update format of array declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants