Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding issues in koan topics #347

Merged
merged 9 commits into from
Jan 19, 2020
Merged

Fix outstanding issues in koan topics #347

merged 9 commits into from
Jan 19, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Jan 18, 2020

PR Summary

Fixes outstanding issues in several koan files. Some changes are relatively minor, others are a bit more extensive depending on the scope of the issue(s) in the file.

Context

Fixes #342
Fixes #341
Fixes #340
Fixes #339
Fixes #337
Fixes #334
Fixes #335
Fixes #332
Fixes #330

Many thanks to @joewatts, @JeffChristman, @scottone, and @figueroadavid for finding these issues; feel free to leave a review / comment on this PR if you feel the solution could use more.

Changes

Fixes issues in:

  • AboutModules
  • AboutTeeObject
  • AboutMeasureObject
  • AboutSelectObject
  • AboutAssignmentAndArithmetic
  • AboutDiscovery
  • AboutArrays

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt labels Jan 18, 2020
@vexx32 vexx32 added this to In progress in Koan Topic Tracking via automation Jan 18, 2020
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Jan 19, 2020
@vexx32 vexx32 merged commit f1b5022 into master Jan 19, 2020
Koan Topic Tracking automation moved this from In progress to Done Jan 19, 2020
@vexx32 vexx32 deleted the Koans/FixIssues branch January 19, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment