Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with 'AboutTeeObject.Koans.ps1 #341

Closed
ghost opened this issue Jan 6, 2020 · 1 comment · Fixed by #347
Closed

Issues with 'AboutTeeObject.Koans.ps1 #341

ghost opened this issue Jan 6, 2020 · 1 comment · Fixed by #347
Assignees
Labels
Category-Koans Invoking the Great Doubt Issue-Enhancement 🎉 Make it better!

Comments

@ghost
Copy link

ghost commented Jan 6, 2020

ISSUE 1 'can store the object(s) into a variable'

Original Line 22

$Values = 'alpha', 'beta', 'gamma'
@( '____', '____', '____', '____') | Tee-Object -Variable 'Numbers' | Should -Be $Values

Modified Line 22

$Values = 'alpha', 'beta', 'gamma'
@( '____', '____', '____') | Tee-Object -Variable 'Numbers' | Should -Be $Values

Once again depending on the intent of the developer.

If the intent was to only supply enough slots for the values located in $Values then there needs to be one less placeholder.
If the intent is to keep the individual working through the tests on their toes so they realize that there is one too many place holders then this is good to go. However, you may have folk searching the Issues to see if this has been reported.

ISSUE 2 'can also store the object(s) into a file'

Original Line 33

@( '__','__','3','__','__') | Should -Be $Stored

Modified Line 33 and add a line 34

@('__','__', '0.33', '__','__',) | Should -Be $Stored
Remove-Item -$File -Force -ErrorAction SilentlyContinue

When dividing 1 by a number the only way to get a whole number is to divide by 1, All other values are going to be fractions, so a whole value of 3 doesn't work
Also we really should be good citizens and clean up after ourselves.

@ghost ghost added Category-Koans Invoking the Great Doubt Issue-Discussion Let's talk about it! labels Jan 6, 2020
@vexx32
Copy link
Owner

vexx32 commented Jan 8, 2020

Thanks for submitting this! These all look like good changes to make. Thanks! 😊

@vexx32 vexx32 added Good First Issue ❇️ Should be quick and easy! Hacktoberfest 💻 Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. Issue-Enhancement 🎉 Make it better! and removed Issue-Discussion Let's talk about it! labels Jan 8, 2020
@vexx32 vexx32 removed Hacktoberfest 💻 Good First Issue ❇️ Should be quick and easy! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. labels Jan 15, 2020
@vexx32 vexx32 self-assigned this Jan 18, 2020
vexx32 added a commit that referenced this issue Jan 18, 2020
Fixes #341

Also added a new koan to show when the variable is created
vexx32 added a commit that referenced this issue Jan 19, 2020
* 🔧 Resolve issues in AboutModules

Fixes #342

* 🔧 Fix issues in AboutTeeObject

Fixes #341

Also added a new koan to show when the variable is created

* 🔧 Fix issues in AboutMeasureObject

Fixes #340

* 🔧 Fix issues in AboutSelectObject

Fixes #339

Fixes #337

* 🔧 Fix issue in AboutAssignmentAndArithmetic

Fixes #334

* 🔧 Fix issues in AboutDiscovery

Fixes #335

Fixes #332

* 🔧 ♻️ Fix up AboutArrays

Fixes #330

* 🔧 Fix missing variable reference

* 🎨 Update format of array declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt Issue-Enhancement 🎉 Make it better!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant