Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize-KoanDirectory parameter and confirmation could be misleading. #15

Closed
ghost opened this issue Jul 14, 2018 · 4 comments
Closed
Assignees
Labels
Issue-Enhancement 🎉 Make it better!

Comments

@ghost
Copy link

ghost commented Jul 14, 2018

From issue #12

So either we need to change the ConfirmImpact of the function to High or we need to alter the call that the Get-Enlightenment function does with the -Reset switch to call the Initialize-KoanDirectory function with the -Confirm switch.

My opinion is, Initialize-KoanDirectory is not an exported function, so the simplest option is to remove the -FirstImport parameter and set ConfirmImpact to High.

Could easily be convinced the other direction.

@vexx32
Copy link
Owner

vexx32 commented Jul 14, 2018

Either route we go, I want the 'first run', so to speak, to execute without confirmation (because the test for whether the koan files are present is already run). So I guess that means... removing -FirstRun and just having the initial run be executed with -Confirm:$false, which amounts to much the same.

Unless you think it would be better to have it be an additional setup step, which... I mean, wouldn't be bad, but I think it would be a little unnecessary.

@ghost
Copy link
Author

ghost commented Jul 14, 2018

Another item to consider as we work on issue #13 unit testing might get weird if every time we want to test it has to import the entire psm1. Not a huge deal, just thinking out loud.

@vexx32
Copy link
Owner

vexx32 commented Jul 14, 2018

In what way? Importing the PSM1 shouldn't be a big deal. We can either break it out into functions (and combine it with a build script for releases) or just add some bits and pieces so that it doesn't create scores of koan files when we're just testing the main functions, etc., etc.

@vexx32
Copy link
Owner

vexx32 commented Jul 14, 2018

Should be good to go for now. @BrandonLundt you may want to update #16 with the new code & syntax so you don't have to edit after merging. 😄

@vexx32 vexx32 closed this as completed Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement 🎉 Make it better!
Projects
None yet
Development

No branches or pull requests

1 participant