-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for missing trusts for Magnum cluster deletion #8
Comments
@ricolin looks clean, +2 from my side, I guess you'll have to shop other reviews :) |
@ricolin looks like it landed, wanna push up some back ports too and put them here? |
This merged today, will push for stable branches |
okay stable branch merged https://review.opendev.org/c/openstack/magnum/+/854136 |
I guess we can close this now. |
@ricolin indeed, this can be closed, but also with magnum-cluster-api, we're leveraging appcreds instead which should be much neater. |
In the referenced issue, we are failing to delete a cluster because the trust is already gone, we should handle that exception and just pass through if it's already gone instead of failing because we can't delete something that already doesn't exist.
The text was updated successfully, but these errors were encountered: