Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for missing trusts for Magnum cluster deletion #8

Closed
mnaser opened this issue Jul 22, 2022 · 7 comments
Closed

Allow for missing trusts for Magnum cluster deletion #8

mnaser opened this issue Jul 22, 2022 · 7 comments
Assignees

Comments

@mnaser
Copy link
Member

mnaser commented Jul 22, 2022

In the referenced issue, we are failing to delete a cluster because the trust is already gone, we should handle that exception and just pass through if it's already gone instead of failing because we can't delete something that already doesn't exist.

@ricolin
Copy link
Member

ricolin commented Aug 12, 2022

@mnaser
Copy link
Member Author

mnaser commented Aug 12, 2022

@ricolin looks clean, +2 from my side, I guess you'll have to shop other reviews :)

@mnaser
Copy link
Member Author

mnaser commented Aug 23, 2022

@ricolin looks like it landed, wanna push up some back ports too and put them here?

@ricolin
Copy link
Member

ricolin commented Aug 23, 2022

This merged today, will push for stable branches

@mnaser mnaser transferred this issue from another repository Aug 29, 2022
@ricolin
Copy link
Member

ricolin commented Oct 14, 2022

okay stable branch merged https://review.opendev.org/c/openstack/magnum/+/854136
thanks @mnaser

@ricolin
Copy link
Member

ricolin commented Oct 14, 2022

I guess we can close this now.

@mnaser
Copy link
Member Author

mnaser commented Oct 26, 2022

@ricolin indeed, this can be closed, but also with magnum-cluster-api, we're leveraging appcreds instead which should be much neater.

@mnaser mnaser closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants