Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling for default volume #110

Closed
mnaser opened this issue Apr 28, 2023 · 2 comments · Fixed by #145
Closed

Better handling for default volume #110

mnaser opened this issue Apr 28, 2023 · 2 comments · Fixed by #145
Assignees
@okozachenko1203

Comments

@mnaser
Copy link
Member

mnaser commented Apr 28, 2023

The default volume is not properly selected, we should either rely on Cinder to select the default volume if none is specified or fail early.
@okozachenko1203
Copy link
Member

@mnaser could you share more context here?
Default volume means boot_volume_type or etcd_volume_type?

@mnaser
Copy link
Member Author

mnaser commented Jun 30, 2023

@mnaser could you share more context here? Default volume means boot_volume_type or etcd_volume_type?

Correct, we're using this function:

https://github.com/vexxhost/magnum/blob/cf2f0659ff255eae56040e0ecc64c1138cde7fe0/magnum/common/cinder.py#L30-L32

Essentially, it should not be _get_random_volume_type but maybe instead we should detect what is the default volume type in Cinder and use that?

@okozachenko1203 okozachenko1203 mentioned this issue Jul 3, 2023
Closed
@okozachenko1203 okozachenko1203 self-assigned this Jul 3, 2023
@mnaser mnaser linked a pull request Jul 4, 2023 that will close this issue
feat: add 1.27 + jammy + conformance #145
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okozachenko1203 okozachenko1203

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mnaser @okozachenko1203