Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all load balancers pre-delete #6

Closed
mnaser opened this issue Oct 26, 2022 · 2 comments · Fixed by #25 or #338
Closed

Remove all load balancers pre-delete #6

mnaser opened this issue Oct 26, 2022 · 2 comments · Fixed by #25 or #338
Labels
priority: high High priority issues

Comments

@mnaser
Copy link
Member

mnaser commented Oct 26, 2022

At the moment, the load balancers are not removed with CAPO.

We can work-around this by doing something similar to what Magnum does with cleaning up the resources:

https://github.com/openstack/magnum/blob/0ee8abeed0ab90baee98a92cab7c684313bab906/magnum/drivers/heat/driver.py#L306-L311

FTR, pre_delete_cluster is manually called so we can just add it at the top of our delete_cluster. The function that's already implemented seems tied to Heat, so these two parts of code should help:

https://github.com/openstack/magnum/blob/0ee8abeed0ab90baee98a92cab7c684313bab906/magnum/common/octavia.py#L89-L101
https://github.com/openstack/magnum/blob/0ee8abeed0ab90baee98a92cab7c684313bab906/magnum/common/octavia.py#L131-L137

With that in place, we'll be able to wipe all of the resources. However, the one thing to investigate is the cluster UUID in the description and what that is set to with CAPI to make sure the regex works right.

@mnaser mnaser added priority: medium Medium priority issues priority: high High priority issues and removed priority: medium Medium priority issues labels Oct 26, 2022
@mnaser
Copy link
Member Author

mnaser commented Nov 1, 2022

@mnaser mnaser closed this as completed in 513d0ff Nov 10, 2022
This was referenced Jul 31, 2023
This was referenced Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority issues
Projects
None yet
1 participant