Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out a better way to package ruptura.dll #4

Closed
alexrp opened this issue Jul 2, 2022 · 2 comments
Closed

Figure out a better way to package ruptura.dll #4

alexrp opened this issue Jul 2, 2022 · 2 comments
Labels
area: build Issues related to the build system. area: injection Issues related to the assembly injection APIs.
Milestone
v1.0

Comments

@alexrp
Copy link
Member

alexrp commented Jul 2, 2022

ruptura/src/injection/injection.csproj

Lines 34 to 49 in d8b4eb4

<!-- TODO: This packaging strategy is bad for future code signing. -->
<Target Name="_EmbedModule"
BeforeTargets="BeforeResGen">
<MSBuild Projects="../module/module.cproj"
Targets="GetTargetPath">
<Output TaskParameter="TargetOutputs"
ItemName="_ModulePath" />
</MSBuild>
<ItemGroup>
<EmbeddedResource Include="@(_ModulePath)"
LogicalName="ruptura.dll"
Type="Non-Resx"
WithCulture="false" />
</ItemGroup>
</Target>

@alexrp alexrp added state: blocked Issues that are blocked on some other issue or work. type: bug area: build Issues related to the build system. area: injection Issues related to the assembly injection APIs. labels Jul 2, 2022
@alexrp alexrp added this to the 1.0 milestone Jul 2, 2022
@alexrp alexrp self-assigned this Jul 2, 2022
@alexrp
Copy link
Member Author

alexrp commented Jul 2, 2022

Ideally we would ship it next to Vezel.Ruptura.Injection.dll. Maybe as a Content item? (It can't go into runtimes/<rid>/native since it's specific to the target process's bitness, not the injector process's bitness.)

@alexrp
Copy link
Member Author

alexrp commented Jul 5, 2022

Content seems to be the way to go. Just need to figure out at what point in the build it is appropriate to dynamically add Content items.

@alexrp alexrp closed this as completed in 5d2b7df Jul 5, 2022
@alexrp alexrp removed the state: blocked Issues that are blocked on some other issue or work. label Jul 5, 2022
@alexrp alexrp removed their assignment Jan 27, 2024
@alexrp alexrp removed the type: bug label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: build Issues related to the build system. area: injection Issues related to the assembly injection APIs.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp