Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethinking structure of kgram_freqs and sbo_preds object #11

Closed
vgherard opened this issue Nov 3, 2020 · 1 comment · Fixed by #18
Closed

Rethinking structure of kgram_freqs and sbo_preds object #11

vgherard opened this issue Nov 3, 2020 · 1 comment · Fixed by #18
Assignees
@vgherard
Labels
enhancement New feature or request

Comments

@vgherard
Copy link
Owner

vgherard commented Nov 3, 2020

  1. From the UI point of view, components such as n, L or lambda would probably appear more naturally as attributes than list elements.

  2. Maybe a simple list (rather than a matrix) would be a better fit for actual kgram_freqs and prediction tables. This could potentially help solving the first part of Huge memory allocations from predict.sbo_preds #10; also would allow to store RLE encoded word sequences and regular sequences in a single object.
@vgherard vgherard added the enhancement New feature or request label Nov 3, 2020
@vgherard vgherard self-assigned this Nov 3, 2020
@vgherard vgherard linked a pull request Nov 9, 2020 that will close this issue
Set metadata as attributes in kgram_freqs and sbo_preds objects - added summary() method for both #18
Merged
@vgherard
Copy link
Owner Author

vgherard commented Nov 9, 2020 •
edited
Loading

Second point requires more thought, opening a separate issue (#19) now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgherard vgherard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@vgherard