Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inclusion of xg and gcsa indexes in git repo (lrc_kir) #478

Closed
ekg opened this issue Sep 15, 2016 · 4 comments
Closed

inclusion of xg and gcsa indexes in git repo (lrc_kir) #478

ekg opened this issue Sep 15, 2016 · 4 comments

Comments

@ekg
Copy link
Member

ekg commented Sep 15, 2016

@adamnovak I just noticed that we've included a few indexes in the repo (test/graphs/refonly-lrc_kir.vg.gcsa for instance). These come to a few mb, which will increase the bulk of the repository. I'm more concerned that they'll need to be updated when we change index formats. When updating binary files, git isn't very smart. It will just add several megabytes to the repo. Is it OK if I remove these?

@adamnovak
Copy link
Member

You can try. But they might be in there for the tests; they may need to be
regenerated dynamically when you run the tests, which will add to the test
runtime.

On Thu, Sep 15, 2016 at 10:46 AM, Erik Garrison notifications@github.com
wrote:

@adamnovak https://github.com/adamnovak I just noticed that we've
included a few indexes in the repo (test/graphs/refonly-lrc_kir.vg.gcsa
for instance). These come to a few mb, which will increase the bulk of the
repository. I'm more concerned that they'll need to be updated when we
change index formats. When updating binary files, git isn't very smart. It
will just add several megabytes to the repo. Is it OK if I remove these?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#478, or mute the thread
https://github.com/notifications/unsubscribe-auth/AE0_X_DTgwv7k7lsRyBZjB2j5JhfJzLiks5qqYSNgaJpZM4J-JVO
.

@ekg
Copy link
Member Author

ekg commented Sep 15, 2016

It adds a handful of secThis is true. It takes about 30 seconds to generate them on my system.

However, we will increase the repo size by 2.5MB every time we update the index formats. What do you think?

@adamnovak
Copy link
Member

Maybe we can keep them in Github LFS or something, even though they aren't
large.

We could also just delete them. Or preserve them between test runs.

On Thu, Sep 15, 2016 at 11:36 AM, Erik Garrison notifications@github.com
wrote:

It adds a handful of secThis is true. It takes about 30 seconds to
generate them on my system.

However, we will increase the repo size by 2.5MB every time we update the
index formats. What do you think?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#478 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE0_XzuS6PyX4eIezlykFc2xBiHumXgmks5qqZAugaJpZM4J-JVO
.

@ekg
Copy link
Member Author

ekg commented Sep 15, 2016

I've deleted them in the fragment-length branch. I can undo it if you'd
prefer.

I think we will save 30 seconds in other ways when the default mapping
algorithm changes.

On Thu, Sep 15, 2016 at 9:01 PM adamnovak notifications@github.com wrote:

Maybe we can keep them in Github LFS or something, even though they aren't
large.

We could also just delete them. Or preserve them between test runs.

On Thu, Sep 15, 2016 at 11:36 AM, Erik Garrison notifications@github.com
wrote:

It adds a handful of secThis is true. It takes about 30 seconds to
generate them on my system.

However, we will increase the repo size by 2.5MB every time we update the
index formats. What do you think?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#478 (comment), or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AE0_XzuS6PyX4eIezlykFc2xBiHumXgmks5qqZAugaJpZM4J-JVO

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#478 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI4EfnaLIFwhhQNrAEjJsoXD19sjKa9ks5qqZX9gaJpZM4J-JVO
.

@ekg ekg closed this as completed Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants