Encapsulate the host interface name into the VM pool and tap manager #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuriousGeorgiy
force-pushed
the
encapsulate-host-interface-into-vm-pool-and-tap-manager
branch
3 times, most recently
from
24f3340
to
254965a
Compare
ustiugov
approved these changes
Sep 12, 2023
Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
Currently, the host interface name is separated from the VM pool and tap manager, and as a result, it needs to be passed to all VM pool methods. This is inconvenient, so encapsulate the host interface name into the VM pool and tap manager. Closes vhive-serverless#810 Part of vhive-serverless#794 Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
CuriousGeorgiy
force-pushed
the
encapsulate-host-interface-into-vm-pool-and-tap-manager
branch
from
254965a
to
c27b6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in
getEnvValerror messageEncapsulate the host interface name into the VM pool and tap manager
Currently, the host interface name is separated from the VM pool and tap
manager, and as a result, it needs to be passed to all VM pool methods.
This is inconvenient, and so encapsulate the host interface name into the
VM pool and tap manager.
Closes #810
Part of #794
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.